Implement json2typescript 1.5.0-rc.0

[andreas-aeschlimann]

I would like to inform you about the newest update of json2typescript. It is currently in RC state.

There are no breaking changes, but some deprecations and property name changes. Everything should still work as expected.

[andreas-aeschlimann]

Does it work for you, @kilchenmann?

[kilchenmann]

@andreas-aeschlimann Thank you for the information. I'm sorry, I didn't saw your first comment and we haven't updated json2typescript yet.

[kilchenmann]

I updated now json2typescript to the mentioned version (s. #371).

First I had to update some imports (e.g. PropertyMatchingRule) but it's fine.
Then I had other minor issues which were also easy to fix. But now I'm struggling with the following when running the unit tests. I tried several thing but it's getting even worse 🙈

09 09 2021 05:11:53.738:ERROR [compiler.karma-typescript]: src/models/api-response-data.ts(79,17): error TS2322: Type 'object' is not assignable to type 'T'.
  'T' could be instantiated with an arbitrary type which could be unrelated to 'object'.

09 09 2021 05:11:53.740:ERROR [compiler.karma-typescript]: src/models/api-response-data.ts(79,90): error TS2345: Argument of type 'new () => T' is not assignable to parameter of type 'new () => object'.
  Type 'T' is not assignable to type 'object'.

[andreas-aeschlimann]

I updated now json2typescript to the mentioned version (s. #371).

First I had to update some imports (e.g. PropertyMatchingRule) but it's fine.
Then I had other minor issues which were also easy to fix. But now I'm struggling with the following when running the unit tests. I tried several thing but it's getting even worse 🙈

09 09 2021 05:11:53.738:ERROR [compiler.karma-typescript]: src/models/api-response-data.ts(79,17): error TS2322: Type 'object' is not assignable to type 'T'.
  'T' could be instantiated with an arbitrary type which could be unrelated to 'object'.

09 09 2021 05:11:53.740:ERROR [compiler.karma-typescript]: src/models/api-response-data.ts(79,90): error TS2345: Argument of type 'new () => T' is not assignable to parameter of type 'new () => object'.
  Type 'T' is not assignable to type 'object'.

It looks like some types were a bit inaccurate in the original code. There is no breaking change, but some types are checked more consistently so this can happen.

I think the problem is that ajaxResponse.response is of type object instead of type any. I would try to write

responseData.body = jsonConvert.deserializeObject(ajaxResponse.response as any, dataType);.

Does that help? If not, which operation causes the error?

[kilchenmann]

It looks like some types were a bit inaccurate in the original code.

Yes, this is also what I thought.

No worries. Go ahead and release the new version of json2typescript. I will have a look at the update on our side later.