Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling CORS everywhere #362

Open
julsraemy opened this issue Nov 18, 2021 · 1 comment
Open

Enabling CORS everywhere #362

julsraemy opened this issue Nov 18, 2021 · 1 comment
Assignees
@lrosenth
Labels
enhancement

Comments

@julsraemy
Copy link
Contributor

Currently, CORS headers are enabled within the info.json that SIPI delivers (access-control-allow-origin: *) but they are not enabled in images and documents in server. This is an important issue that needs to resolved.
@subotic
Copy link
Contributor

subotic commented Dec 8, 2021

also, having access-control-allow-origin set to * is a problem we have run into: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSNotSupportingCredentials

Basically, access-control-allow-origin needs to always mirror the origin of the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrosenth lrosenth

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@subotic @lrosenth @julsraemy