Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbt-synapse to 1.7.latest #127

Closed
colin-rogers-dbt opened this issue Feb 28, 2024 · 3 comments · Fixed by #128
Closed

Add dbt-synapse to 1.7.latest #127

colin-rogers-dbt opened this issue Feb 28, 2024 · 3 comments · Fixed by #128
Assignees
Labels
enhancement New feature or request

Comments

@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Feb 28, 2024

Now that dbt-synapse supports 1.7 we want to begin including it in bundles. This ticket only covers adding the adapter to requirements and does not include any further validation/testing

Acceptance Criteria:
The version has been added. If it fails for any reason, stop the ticket and discuss in the channel.

@Fleid Fleid added the enhancement New feature or request label Feb 28, 2024
@mikealfare mikealfare linked a pull request Feb 29, 2024 that will close this issue
@mikealfare
Copy link
Contributor

Moving to blocked. Adding dbt-synapse to the bundle appears to require py311 to build.

@mikealfare
Copy link
Contributor

This might have been a false alarm, looking further into the failure in the background of other tasks.

@mikealfare
Copy link
Contributor

So the tests are passing for 1.0 through 1.7. They're failing on main/1.8. I don't know if it's happening because it's 1.8 or because it's installing from GitHub. The dependency called out in the error is hatchling, which is only used in 1.8. But it could arise from other combinations of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants