Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrousel2: replace isFullscreen and isNavigationHide into a new prop navigationPosition #579

Open
2fd opened this issue Mar 3, 2023 · 0 comments
Assignees

Comments

@2fd
Copy link
Contributor

2fd commented Mar 3, 2023

  • deprecate props isFullscreen and isNavigationHide
  • add new enum NavigationPosition
  • add a new prop navigationPositition: NavigationPosition where:
    • navigationPosition={NavigationPosition.Outer}is the default value and is equal to isFullscreen={false} and isNavigationHide={false}
    • navigationPosition={NavigationPosition.Inner}is equal to isFullscreen={true} and isNavigationHide={false}
    • navigationPosition={NavigationPosition.None}is equal to isNavigationHide={false}
enum NavigationPosition {
    None = 'none',
    Inner = 'inner',
    Outer = 'outer',
}

type Carousel2Props = {
    // ...
    navigationPosition: NavigationPosition
    // ...
}
@2fd 2fd assigned 2fd and braianj Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants