From f5bf83a043bc700e0f7045ee40ba5c4494e81e92 Mon Sep 17 00:00:00 2001 From: Andy Espagnolo Date: Thu, 19 Oct 2023 18:28:00 -0300 Subject: [PATCH] chore: update pull request template --- .github/pull_request_template.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b393c4d11..5b9d13fac 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,12 +8,16 @@ E.g: *Closes/Fixes #1234* - [ ] The code is properly commented on and provides context when needed (complex feature or hard to understand) - [ ] **Functionality validation** - [ ] Feature working as described in the related issue - - [ ] Does this PR need environment variables to be set? If yes, have they been set? - - [ ] New API endpoints are properly documented + - [ ] New environmental variables have been set - [ ] New functions are properly tested (When should we add tests?) - [ ] Code errors are being logged in the code health service - [ ] **Product validation** - [ ] UI changes look the same as in Figma - [ ] Usage events are being sent to the product analytics service - [ ] New common components have been documented in Storybook - - [ ] Preview link if it’s a customer facing issue \ No newline at end of file + - [ ] Preview link if it’s a customer facing issue +- [ ] **Documentation** + - [ ] README updated + - [ ] New API changes are properly documented +- [ ] **Accessibility** + - [ ] UI changes are accessible \ No newline at end of file