From ade19be9f4992ffa3337ce29808066c59beb4991 Mon Sep 17 00:00:00 2001
From: Lautaro Petaccio <lausuper@gmail.com>
Date: Fri, 8 Mar 2024 15:57:32 -0300
Subject: [PATCH] fix: Fixes

---
 .../components/AssetPage/BestBuyingOption/BestBuyingOption.tsx  | 2 +-
 webapp/src/components/Menu/DropdownMenu/DropdownMenu.tsx        | 2 +-
 .../components/OnSaleOrRentList/OnSaleOrRentList.container.ts   | 1 -
 webapp/src/components/Price/Price.container.ts                  | 1 -
 webapp/src/utils/test.tsx                                       | 2 +-
 webapp/tsconfig.json                                            | 1 -
 6 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/webapp/src/components/AssetPage/BestBuyingOption/BestBuyingOption.tsx b/webapp/src/components/AssetPage/BestBuyingOption/BestBuyingOption.tsx
index 07ca512469..57ad078bbd 100644
--- a/webapp/src/components/AssetPage/BestBuyingOption/BestBuyingOption.tsx
+++ b/webapp/src/components/AssetPage/BestBuyingOption/BestBuyingOption.tsx
@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from 'react'
 import { Link, useHistory, useLocation } from 'react-router-dom'
 import { t } from 'decentraland-dapps/dist/modules/translation/utils'
-import { Bid, BidSortBy, Item, ListingStatus, Network, Order, OrderFilters, OrderSortBy, Rarity } from '@dcl/schemas'
+import { Bid, BidSortBy, ListingStatus, Network, Order, OrderFilters, OrderSortBy, Rarity } from '@dcl/schemas'
 import { Button, Popup } from 'decentraland-ui'
 import { getExpirationDateLabel } from '../../../lib/date'
 import { locations } from '../../../modules/routing/locations'
diff --git a/webapp/src/components/Menu/DropdownMenu/DropdownMenu.tsx b/webapp/src/components/Menu/DropdownMenu/DropdownMenu.tsx
index 75cfd73d84..94b1fef1f9 100644
--- a/webapp/src/components/Menu/DropdownMenu/DropdownMenu.tsx
+++ b/webapp/src/components/Menu/DropdownMenu/DropdownMenu.tsx
@@ -36,7 +36,7 @@ const DropdownMenu = <T extends unknown>(props: Props<T>) => {
         className={classNames({ open: isDropdownOpen })}
       />
       <ul className="submenu">
-        {values.includes(currentValue) && isDropdownOpen
+        {currentValue && values.includes(currentValue) && isDropdownOpen
           ? values
               .slice(1)
               .map((value, index) => (
diff --git a/webapp/src/components/OnSaleOrRentList/OnSaleOrRentList.container.ts b/webapp/src/components/OnSaleOrRentList/OnSaleOrRentList.container.ts
index 4966c69b6e..34b21a7a37 100644
--- a/webapp/src/components/OnSaleOrRentList/OnSaleOrRentList.container.ts
+++ b/webapp/src/components/OnSaleOrRentList/OnSaleOrRentList.container.ts
@@ -1,5 +1,4 @@
 import { connect } from 'react-redux'
-import { Item } from '@dcl/schemas'
 import { isLoadingType } from 'decentraland-dapps/dist/modules/loading/selectors'
 import { Authorization } from 'decentraland-dapps/dist/modules/authorization/types'
 import { fetchAuthorizationsRequest, revokeTokenRequest } from 'decentraland-dapps/dist/modules/authorization/actions'
diff --git a/webapp/src/components/Price/Price.container.ts b/webapp/src/components/Price/Price.container.ts
index 80e6e845a8..9f7ab4b58c 100644
--- a/webapp/src/components/Price/Price.container.ts
+++ b/webapp/src/components/Price/Price.container.ts
@@ -3,7 +3,6 @@ import { MapStateProps, OwnProps } from './Price.types'
 import Price from './Price'
 import { RootState } from '../../modules/reducer'
 import { getCurrentOrder } from '../../modules/order/selectors'
-import { Item } from '@dcl/schemas'
 
 const mapState = (state: RootState, { asset }: OwnProps): MapStateProps => {
   let price: string | undefined
diff --git a/webapp/src/utils/test.tsx b/webapp/src/utils/test.tsx
index c60406ebfd..67889e7e64 100644
--- a/webapp/src/utils/test.tsx
+++ b/webapp/src/utils/test.tsx
@@ -12,7 +12,7 @@ import { RootState } from '../modules/reducer'
 import { initTestStore } from '../modules/store'
 import * as locales from '../modules/translation/locales'
 
-const allTranslations = mergeTranslations(flatten(en), flatten(locales.en))
+const allTranslations = mergeTranslations(flatten(en), flatten(locales.en) as any)
 
 export function renderWithProviders(
   component: JSX.Element,
diff --git a/webapp/tsconfig.json b/webapp/tsconfig.json
index 31032ef6dd..8f09e241a2 100644
--- a/webapp/tsconfig.json
+++ b/webapp/tsconfig.json
@@ -21,7 +21,6 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
-    "types": ["vite/client", "jest", "node"],
   },
   "include": ["src", ".eslintrc.js", "vite.config.ts", "jest.config.ts", ".eslintrc.cjs"],
   "references": [{ "path": "./tsconfig.node.json" }]