Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruned tx is requested with /address/Ds... all tx fail to load #10

Open
alexlyp opened this issue Feb 26, 2016 · 3 comments
Open

Pruned tx is requested with /address/Ds... all tx fail to load #10

alexlyp opened this issue Feb 26, 2016 · 3 comments
Labels

Comments

@alexlyp
Copy link
Member

alexlyp commented Feb 26, 2016

When a tx is not found via RPC request during Address.update it errors out incorrectly.

Appears that getTransaction in app/controllers/transactions.js has incorrect callback return.

Should return err and null txinfo, then above it should catch the err and carry on loading tx

@jcvernaleo jcvernaleo added the bug label Apr 11, 2016
@YSTomar
Copy link

YSTomar commented Nov 6, 2017

@alexlyp, I hope you are talking the about the insight-api codebase for "Appears that getTransaction in app/controllers/transactions.js has incorrect callback return."

currently error message is "Appears that getTransaction in app/controllers/transactions.js has incorrect callback return.", It refers to https://github.com/decred/insight-api/blob/23d38a0bfcc3cafebe9318d288891512fff33eb1/app/controllers/transactions.js#L96

Please let me know for this ticket can I work on insight-api, or needed to create separate ticket on insight-api.

@alexlyp
Copy link
Member Author

alexlyp commented Nov 6, 2017

Yes, please do any work on insight-api that you deem necessary.

@YSTomar
Copy link

YSTomar commented Nov 7, 2017

Please review the PR

alexlyp pushed a commit to decred/insight-api that referenced this issue Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants