[cms] Proposal owner invoice approval #1243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
force-pushed
the
ayp_proposal_owner_approve
branch
from
e524028 to
b4ab4e3
Compare
alexlyp
force-pushed
the
ayp_proposal_owner_approve
branch
from
b4ab4e3 to
0ae8f0c
Compare
alexlyp
force-pushed
the
ayp_proposal_owner_approve
branch
from
0ae8f0c to
d77d192
Compare
alexlyp
force-pushed
the
ayp_proposal_owner_approve
branch
from
d77d192 to
3b3cce7
Compare
@alexlyp to clarify
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1225
This PR adds the ability for users that are designated as "proposal owners" to approve line items that have been billed against the owned proposal.
Now proposal owners are able to see invoice details that will show them line items of proposals that they own. They can now also comment on an invoice to communicate with the invoice creator if need be. They will be able to see any comment thread that they started, but not admin or potentially other proposal owner comments.
If the invoice looks appropriate then they can "approve" the invoice. This request will update the invoice record on the backend with a new metadata type that contains the line items payload and their signature of them. This is more or less "proof" that they have approved those specific line items.
Currently, there is no more handling of approved invoices other than just a list of proposal tokens in the invoice record. In the future we can update status or something more involved.