Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DH-18086: Update jsapi types #2338

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jan 9, 2025

DH-18086:

  • Upgrade @deephaven/jsapi-types to ^1.0.0-dev0.37.2
  • Fixed types

onError(new DownsamplingError(downsamplingError));
onError(
new DownsamplingError(
downsamplingError == null ? undefined : `${downsamplingError}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a runtime change, but the DownsamplingError constructor should be stringifying it's first arg anyway.

): DhType.IdeConnection {
log.info(`Starting connection to '${websocketUrl}'...`);

return new dh.IdeConnection(websocketUrl);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdeConnection is a protected constructor which now shows a ts error in the 0.37+ types. The wrapping connection doesn't appear to be called anywhere, so deleting it.

Per @niloc132 this call shouldn't have worked as of early 2023.

@bmingles bmingles requested review from a team and dgodinez-dh and removed request for a team January 9, 2025 19:26
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 46.71%. Comparing base (3608b15) to head (bf1b44c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/console/src/ConsoleStatusBar.tsx 14.28% 6 Missing ⚠️
...s/app-utils/src/components/ConnectionBootstrap.tsx 0.00% 4 Missing ⚠️
packages/chart/src/Chart.tsx 0.00% 4 Missing ⚠️
packages/chart/src/FigureChartModel.ts 33.33% 2 Missing ⚠️
packages/console/src/Console.tsx 0.00% 2 Missing ⚠️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 33.33% 2 Missing ⚠️
...-grid/src/AdvancedFilterCreatorSelectValueList.tsx 0.00% 1 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 0.00% 1 Missing ⚠️
packages/jsapi-components/src/TableDropdown.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2338    +/-   ##
========================================
  Coverage   46.71%   46.71%            
========================================
  Files         704      704            
  Lines       39031    39030     -1     
  Branches     9752     9938   +186     
========================================
  Hits        18234    18234            
+ Misses      20786    20742    -44     
- Partials       11       54    +43     
Flag Coverage Δ
unit 46.71% <17.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit 17eca65 into deephaven:main Jan 10, 2025
11 checks passed
@bmingles bmingles deleted the DH-18086_update-jsapi-types branch January 10, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants