-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: DH-18086: Update jsapi types #2338
chore: DH-18086: Update jsapi types #2338
Conversation
onError(new DownsamplingError(downsamplingError)); | ||
onError( | ||
new DownsamplingError( | ||
downsamplingError == null ? undefined : `${downsamplingError}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a runtime change, but the DownsamplingError constructor should be stringifying it's first arg anyway.
): DhType.IdeConnection { | ||
log.info(`Starting connection to '${websocketUrl}'...`); | ||
|
||
return new dh.IdeConnection(websocketUrl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IdeConnection
is a protected constructor which now shows a ts error in the 0.37+ types. The wrapping connection doesn't appear to be called anywhere, so deleting it.
Per @niloc132 this call shouldn't have worked as of early 2023.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2338 +/- ##
========================================
Coverage 46.71% 46.71%
========================================
Files 704 704
Lines 39031 39030 -1
Branches 9752 9938 +186
========================================
Hits 18234 18234
+ Misses 20786 20742 -44
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DH-18086: