Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swift compilation #611

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix swift compilation #611

merged 1 commit into from
Jan 16, 2025

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented Jan 16, 2025 •
edited
Loading

Now module map and swift header generates every time except of cases when:

  1. Pod spec has "module_map" == "false" or
  2. Pod spec has "module_map" == "<path_to_module_map>"

According to https://guides.cocoapods.org/syntax/podspec.html#module_map default value is "true"

Fixes defold/extension-ironsource#36

@ekharkunov ekharkunov requested a review from britzl January 16, 2025 12:55
britzl
britzl approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ekharkunov ekharkunov merged commit 993919d into dev Jan 16, 2025
@ekharkunov ekharkunov deleted the fix-swift-compilation branch January 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The extension is not built with the latest version of IS for iOS
2 participants
@ekharkunov @britzl