Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename? #3

Open
plebhash opened this issue Nov 17, 2024 · 2 comments
Open

rename? #3

plebhash opened this issue Nov 17, 2024 · 2 comments

Comments

@plebhash
Copy link
Contributor

plebhash commented Nov 17, 2024

when I first tried to use this tool, I thought it was giving me information about the coinbase of the network tip

admitedly, that was before actually reading the source code 🙈

then I realized that it is actually leveraging Sv2 TDP to monitor for coinbases of Sv2 jobs

suggestion for names that would be better IMO:

  • sv2-tdp-coinbase-monitor
  • sv2-template-coinbase-monitor

maybe there's other better options idk

the main point is that I think this tool would be better understood if it explicitly mentions Sv2 in the naming

@Fi3
Copy link
Contributor

Fi3 commented Nov 18, 2024

yep we can change it no problem, but keep in mind that this is mostly an example of how to use the easy-sv2 library. Of course if someone find it useful and we want to further develop it I'm open to it

@plebhash
Copy link
Contributor Author

plebhash commented Dec 6, 2024

the suggestions above are heavily based on the assumption that this tool will only be used to monitor TDP

but that doesn't have to necessarily be the case, we could also potentially expand functionality

it could also be useful to connect this tool to:

  • JDC (to monitor coinbase under JD Protocol)
  • Pool (to monitor coinbase under Mining Protocol)
  • Proxy (to monitor coinbase under Mining Protocol)

in that case, a better name would be sv2-coinbase-monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants