Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the control examples out of the resource pack #24

Open
aaronlippold opened this issue May 18, 2019 · 4 comments
Open

Move the control examples out of the resource pack #24

aaronlippold opened this issue May 18, 2019 · 4 comments

Comments

@aaronlippold
Copy link
Member

When this is used as a resource pack but the controls are not used it populates the output data with extra data. I think we should split this into a proper resource pack and then an example repo that depends on the resource pack and put the control tests in the example.

@chris-rock
Copy link
Member

hi @aaronlippold thank you for your feedback. I am not sure I fully understand your concern since the resources can already be used as a resource pack. The controls are optional. Can you provide an example?

@aaronlippold
Copy link
Member Author

aaronlippold commented May 19, 2019 via email

@chris-rock
Copy link
Member

@aaronlippold It would be great to have a screenshot and the version that you're using. I cannot see any direct output except for stderr within the resources.

@aaronlippold
Copy link
Member Author

aaronlippold commented May 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants