Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding labels to containers build by devcontainer cli that are based on a Dockerfile (instead of an image) does not work #930

Open
Roemer opened this issue Nov 7, 2024 · 1 comment
Open

Adding labels to containers build by devcontainer cli that are based on a Dockerfile (instead of an image) does not work #930

Roemer opened this issue Nov 7, 2024 · 1 comment
Assignees
@chrmarti
Labels
bug Something isn't working

Comments

@Roemer
Copy link

Roemer commented Nov 7, 2024

A few months ago, the --label property to build was added that adds labels (#846). Unfortunately it seems that this only works when a devcontainer is build that is based directly from an image. If it is based from a Dockerfile, the labels from --label are not added.
I added a test in a PR that shows the problem, see here: #929
@chrmarti chrmarti self-assigned this Dec 17, 2024
@chrmarti chrmarti added the bug Something isn't working label Dec 17, 2024
@chrmarti
Copy link
Contributor

Commented on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrmarti chrmarti

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roemer @chrmarti