You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This gives the error: TypeError: Got both 'ls' and 'linestyle', which are aliases of one another
I expected that this wouldn't give an error, and should be the same as calling replacing ls with linestyle in the call to overplot_points (which doesn't seem to affect the plot anyways).
I think the solution is to remove the line kwargs["linestyle"] = kwargs.pop("linestyle", "none") in the definition of overplot_points in src/corner/core.py. With this line gone, I no longer get this error and all tests are passed when running nox.
This is a small fix but I'd be happy to open a PR for it.
The text was updated successfully, but these errors were encountered:
twhentschel
changed the title
Small bug in overlpot_points
linestyle argument in overlpot_points
Feb 26, 2024
OS: Ubuntu
Python Version: 3.9
Corner Version: v2.2.2
I've found a tiny, probably inconsequential bug in
overplot_points
related to passing the argumentls
to change the linestyleThis gives the error:
TypeError: Got both 'ls' and 'linestyle', which are aliases of one another
I expected that this wouldn't give an error, and should be the same as calling replacing
ls
withlinestyle
in the call tooverplot_points
(which doesn't seem to affect the plot anyways).I think the solution is to remove the line
kwargs["linestyle"] = kwargs.pop("linestyle", "none")
in the definition ofoverplot_points
in src/corner/core.py. With this line gone, I no longer get this error and all tests are passed when runningnox
.This is a small fix but I'd be happy to open a PR for it.
The text was updated successfully, but these errors were encountered: