Gradle spotlessApply fails under Java 21 with 6.23.3 #1944
Labels
Comments
|
Wired, your case should be handled by a6495ed. I can't repro it in LawnchairLauncher/lawnchair#3823: spotless {
java {
palantirJavaFormat()
target("lawnchair/src/**/*.java")
}
kotlin {
ktlint()
target("lawnchair/src/**/*.kt")
}
}Your project is so large, can you create a minimum reproducer? |
|
Why does the size matter? Just checkout and run |
|
@Goooler I noticed your discussion palantir/palantir-java-format#939 (comment) talking about transitive dependencies in Guava. This sounded like exactly the problem I'm having so I manually set |
|
Have you read my comment above? |
|
Yes, that's why I added two comments to this ticket in direct response to your comment... |
|
|
Easier to just fix it myself: #1948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you are submitting a bug, please include the following:
After upgrading to plugin 6.23.3 which is supposed to have a fix for Java 21 support, I still am unable to run
spotlessApplywith Gradle 8.5 and Java 21 temurin. It is unable to resolve the following transitive dependencies and looks as though their version is incorrectly.instead of a semver:com.google.code.findbugs:jsr305:.org.checkerframework:checker-qual:.com.google.errorprone:error_prone_annotations:.8.5
com.diffplug.spotless:spotless-plugin-gradle:6.23.3MacOS 14
hashgraph/hedera-mirror-node#7294
7233-java-21branchspotless { val npmExec = when (System.getProperty("os.name").lowercase().contains("windows")) { true -> Paths.get("npm.cmd") else -> Paths.get("bin", "npm") } val npmSetup = tasks.named("npmSetup").get() as NpmSetupTask val npmExecutable = npmSetup.npmDir.get().asFile.toPath().resolve(npmExec) isEnforceCheck = false if (!System.getenv().containsKey("CI")) { ratchetFrom("origin/main") } format("javascript", { indentWithSpaces(2) licenseHeader(licenseHeader, "$").updateYearWithLatest(true) prettier() .npmExecutable(npmExecutable) .npmInstallCache(Paths.get("${rootProject.rootDir}", ".gradle", "spotless")) .config( mapOf( "bracketSpacing" to false, "printWidth" to 120, "singleQuote" to true, ) ) target("**/*.js") targetExclude("**/node_modules/**", "**/__tests__/integration/*.test.js") }) java { addStep(StripOldLicenseFormatterStep.create()) palantirJavaFormat() licenseHeader(licenseHeader, "package").updateYearWithLatest(true) target("**/*.java") targetExclude("build/**") toggleOffOn() } kotlinGradle({ ktfmt().dropboxStyle() licenseHeader(licenseHeader, "(description|import|plugins)").updateYearWithLatest(true) }) format("miscellaneous", { endWithNewline() indentWithSpaces(2) prettier().npmExecutable(npmExecutable) target("**/*.json", "**/*.md", "**/*.yml", "**/*.yaml") targetExclude("**/node_modules/**", "**/package-lock.json") trimTrailingWhitespace() }) sql { endWithNewline() indentWithSpaces() target("**/*.sql") targetExclude("**/db/migration/v1/*.sql") // Modifying executed SQL will change its checksum trimTrailingWhitespace() } format("xml", { endWithNewline() indentWithSpaces() target("**/*.xml") targetExclude("**/node_modules/**", "**/package-lock.json") trimTrailingWhitespace() }) }gradlew spotless[Apply/Check] --stacktraceIf you're just submitting a feature request or question, no need for the above.
The text was updated successfully, but these errors were encountered: