Skip to content
This repository has been archived by the owner on Jul 8, 2021. It is now read-only.

Add localization support #3

Open
digitalcraftsman opened this issue Mar 9, 2016 · 7 comments · May be fixed by #57
Open

Add localization support #3

digitalcraftsman opened this issue Mar 9, 2016 · 7 comments · May be fixed by #57

Comments

@digitalcraftsman
Copy link
Owner

See gohugoio/hugo/pull/1734

@joeblew99
Copy link

I can add multi-lungual support to this.

Would you accepts PR's on this for the example site ? DE and EN.

Can you give me some pointers to get started.

  • I noticed there is a multi-lingual repo. Is that still current ?
  • what version of hugo are you basing off ?

@JOduMonT
Copy link

@joeblew99 How the localization support is going ?

@joeblew99
Copy link

@JOduMonT nothing at all. I got side tracked :)
also because i did not get a response from @digitalcraftsman, i got discouraged as it sounded like maybe he did not want any PR's

I think now that i18n has stabilised in hugo it makes sense to try again.
what does everyone think ?

@digitalcraftsman
Copy link
Owner Author

also because i did not get a response from @digitalcraftsman, i got discouraged as it sounded like maybe he did not want any PR's

Pardon the late response. I know that I haven't been actively maintaining this theme for a while - but PR's are always welcome. It's planned that I add i18n support while porting the completely overhauled upstream project and do it all at once.

Adding i18n support would only make sense if I've already ported all HTML templates in which I could substitute all hard-coded strings with the i18n template function.

At least this month I'll be busy as well because I've to studying for exams. Hence this theme doesn't get the deserved attention.

Would you accepts PR's on this for the example site ? DE and EN.

As aforementioned, I glad for any kind of contributions. Furthermore, I should mention that I'm German as well. So, it's likely that I'll add support for German and English by default.

@joeblew99
Copy link

@digitalcraftsman Do you know a good reference app i can use as am example for making this repo i18n ?

@digitalcraftsman
Copy link
Owner Author

Currently, I can't think of a larger Hugo site that uses the i18n feature (but the showcase on the Hugo website might list some sites).

A good rule of thumb would be

  • to simply replace all hardcoded strings with i18n "translation-key"
  • to link all pages (not assets) with the [abs/relLangURL](absLangURL, relLangURL). They work similar to abs/relUrl but are language-aware (i.e. add the language prefix in the url automatically)

Feel free to move on if you want to add i18n to the current version of the theme.

@MaartenR MaartenR linked a pull request Feb 9, 2017 that will close this issue
@hudecof
Copy link

hudecof commented Nov 8, 2017

I used your path for i18n.Please could you add also translation for strings in drawer.html like

  • the author
  • on github
  • on twitter
  • contact by email

I did it in my copy already

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@hudecof @JOduMonT @digitalcraftsman @joeblew99 and others