-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts should output the "discovered" value after conducting a binary search #5
Comments
My half implemented plan is to pull the binary chop into a shared function used by the tests. I'll add that in with the refactoring. |
That's a good approach, as there are lots of corner cases for the binary search code to catch, and its obnoxious trying to keep a bunch of delicate separate implementations in sync. I submitted some binary search to the NIST python tool; it deals with the problems that I'm aware of. |
I hope you don't mind if I steal that binary chop code you submitted against the NIST code? |
That's fine. |
As an aside, for biased outputs, the current binary search code seems to be missing the value it is looking for. I've put some data files (and corresponding results, with extensive debugging information) here: |
It would be helpful to output the value that was found in the binary search. Log is a 1-1 function, this can nominally be recovered, but it would be generally useful to just output the value after it is calculated.
The text was updated successfully, but these errors were encountered: