Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix env error #459

Closed
wants to merge 5 commits into from
Closed

fix env error #459

wants to merge 5 commits into from

Conversation

kayceeDev
Copy link

Summary

Fix test

@djeck1432 djeck1432 self-requested a review January 15, 2025 19:07
@kayceeDev kayceeDev marked this pull request as ready for review January 16, 2025 04:41
@@ -16,6 +16,7 @@ export const checkForCRMToken = async (walletAddress) => {
}

try {
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -127,6 +130,7 @@ async function waitForTransaction(txHash) {
export async function closePosition(transactionData) {
const callData = new CallData(abi);
const compiled = callData.compile('close_position', transactionData);
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -110,6 +112,7 @@ export async function sendExtraDepositTransaction(deposit_data, userContractAddr

/* eslint-disable-next-line no-unused-vars */
async function waitForTransaction(txHash) {
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -53,6 +54,7 @@ export async function sendTransaction(loopLiquidityData, contractAddress) {

export async function sendExtraDepositTransaction(deposit_data, userContractAddress) {
try {
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -8,6 +8,7 @@ import { notify, ToastWithLink } from '../components/layout/notifier/Notifier';

export async function sendTransaction(loopLiquidityData, contractAddress) {
try {
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -1,4 +1,4 @@
import { getWallet } from './wallet';
import { connectWallet, getWallet } from './wallet';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -1,11 +1,12 @@
import { getWallet } from './wallet';
import { getWallet, connectWallet } from './wallet';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

import { getDeployContractData } from '../utils/constants';
import { axiosInstance } from '../utils/axios';
import { notify, ToastWithLink } from '../components/layout/notifier/Notifier';

export async function deployContract(walletId) {
try {
// Connect to Starknet wallet
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@@ -84,6 +85,7 @@ export function logout() {

export async function getTokenBalances(walletAddress) {
try {
await connectWallet();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it please, you can't change code to adjust test cases

@djeck1432 djeck1432 linked an issue Jan 16, 2025 that may be closed by this pull request
@djeck1432
Copy link
Owner

@kayceeDev Sorry, should close this PR as not sure that you can manage it

@djeck1432 djeck1432 closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Fix frontend issue related to wallet connection
2 participants