-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix env error #459
fix env error #459
Conversation
frontend/src/services/wallet.js
Outdated
@@ -16,6 +16,7 @@ export const checkForCRMToken = async (walletAddress) => { | |||
} | |||
|
|||
try { | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/transaction.js
Outdated
@@ -127,6 +130,7 @@ async function waitForTransaction(txHash) { | |||
export async function closePosition(transactionData) { | |||
const callData = new CallData(abi); | |||
const compiled = callData.compile('close_position', transactionData); | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/transaction.js
Outdated
@@ -110,6 +112,7 @@ export async function sendExtraDepositTransaction(deposit_data, userContractAddr | |||
|
|||
/* eslint-disable-next-line no-unused-vars */ | |||
async function waitForTransaction(txHash) { | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/transaction.js
Outdated
@@ -53,6 +54,7 @@ export async function sendTransaction(loopLiquidityData, contractAddress) { | |||
|
|||
export async function sendExtraDepositTransaction(deposit_data, userContractAddress) { | |||
try { | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/transaction.js
Outdated
@@ -8,6 +8,7 @@ import { notify, ToastWithLink } from '../components/layout/notifier/Notifier'; | |||
|
|||
export async function sendTransaction(loopLiquidityData, contractAddress) { | |||
try { | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
@@ -1,4 +1,4 @@ | |||
import { getWallet } from './wallet'; | |||
import { connectWallet, getWallet } from './wallet'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
@@ -1,11 +1,12 @@ | |||
import { getWallet } from './wallet'; | |||
import { getWallet, connectWallet } from './wallet'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/contract.js
Outdated
import { getDeployContractData } from '../utils/constants'; | ||
import { axiosInstance } from '../utils/axios'; | ||
import { notify, ToastWithLink } from '../components/layout/notifier/Notifier'; | ||
|
||
export async function deployContract(walletId) { | ||
try { | ||
// Connect to Starknet wallet | ||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
frontend/src/services/wallet.js
Outdated
@@ -84,6 +85,7 @@ export function logout() { | |||
|
|||
export async function getTokenBalances(walletAddress) { | |||
try { | |||
await connectWallet(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it please, you can't change code to adjust test cases
@kayceeDev Sorry, should close this PR as not sure that you can manage it |
Summary
Fix test