From 8016515094c6d8ce533e5656675202bb3ae90ec4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= <postmaster@greg0ire.fr>
Date: Mon, 2 Dec 2024 21:25:04 +0100
Subject: [PATCH] Drop Psalm (#562)

As per our decision during the Hackathon.
---
 .gitattributes                                |  2 --
 .github/workflows/static-analysis.yml         |  2 +-
 .../DoctrineCommandsTest.php                  |  2 +-
 composer.json                                 |  5 +---
 psalm-baseline.xml                            | 21 ---------------
 psalm.xml                                     | 26 -------------------
 6 files changed, 3 insertions(+), 55 deletions(-)
 delete mode 100644 psalm-baseline.xml
 delete mode 100644 psalm.xml

diff --git a/.gitattributes b/.gitattributes
index dbad283..0c3c467 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -9,5 +9,3 @@ phpcs.xml.dist export-ignore
 phpstan.neon export-ignore
 phpstan.neon.dist export-ignore
 phpunit.xml.dist export-ignore
-psalm.xml export-ignore
-psalm-baseline.xml export-ignore
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
index a18a9f1..b2f2a1f 100644
--- a/.github/workflows/static-analysis.yml
+++ b/.github/workflows/static-analysis.yml
@@ -12,4 +12,4 @@ on:
 jobs:
   static-analysis:
     name: "Static Analysis"
-    uses: "doctrine/.github/.github/workflows/static-analysis.yml@5.3.0"
+    uses: "doctrine/.github/.github/workflows/phpstan.yml@5.3.0"
diff --git a/Tests/DependencyInjection/DoctrineCommandsTest.php b/Tests/DependencyInjection/DoctrineCommandsTest.php
index e72f408..c63b7a4 100644
--- a/Tests/DependencyInjection/DoctrineCommandsTest.php
+++ b/Tests/DependencyInjection/DoctrineCommandsTest.php
@@ -51,7 +51,7 @@ public function testCommandRegistered(string $name, string $instance): void
 
     /**
      * @return string[][]
-     * @psalm-return list<array{string, class-string<DoctrineCommand>}>
+     * @phpstan-return list<array{string, class-string<DoctrineCommand>}>
      */
     public function getCommands(): array
     {
diff --git a/composer.json b/composer.json
index 6e1908e..17a00ac 100644
--- a/composer.json
+++ b/composer.json
@@ -37,11 +37,8 @@
         "phpstan/phpstan-symfony": "^1.3",
         "doctrine/orm": "^2.6 || ^3",
         "doctrine/persistence": "^2.0 || ^3 ",
-        "psalm/plugin-phpunit": "^0.18.4",
-        "psalm/plugin-symfony": "^3 || ^5",
         "symfony/phpunit-bridge": "^6.3 || ^7",
-        "symfony/var-exporter": "^5.4 || ^6 || ^7",
-        "vimeo/psalm": "^4.30 || ^5.15"
+        "symfony/var-exporter": "^5.4 || ^6 || ^7"
     },
     "autoload": {
         "psr-4": { "Doctrine\\Bundle\\MigrationsBundle\\": "" },
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
deleted file mode 100644
index fa484db..0000000
--- a/psalm-baseline.xml
+++ /dev/null
@@ -1,21 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.24.0@462c80e31c34e58cc4f750c656be3927e80e550e">
-  <file src="DependencyInjection/Configuration.php">
-    <UndefinedInterfaceMethod>
-      <code><![CDATA[end]]></code>
-    </UndefinedInterfaceMethod>
-  </file>
-  <file src="MigrationsFactory/ContainerAwareMigrationFactory.php">
-    <ContainerDependency>
-      <code><![CDATA[ContainerInterface $container]]></code>
-    </ContainerDependency>
-    <UndefinedClass>
-      <code><![CDATA[ContainerAwareInterface]]></code>
-    </UndefinedClass>
-  </file>
-  <file src="Tests/Fixtures/Migrations/ContainerAwareMigration.php">
-    <UndefinedClass>
-      <code><![CDATA[ContainerAwareInterface]]></code>
-    </UndefinedClass>
-  </file>
-</files>
diff --git a/psalm.xml b/psalm.xml
deleted file mode 100644
index dc18a01..0000000
--- a/psalm.xml
+++ /dev/null
@@ -1,26 +0,0 @@
-<?xml version="1.0"?>
-<psalm
-    errorLevel="4"
-    phpVersion="8.2"
-    findUnusedBaselineEntry="true"
-    findUnusedCode="false"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xmlns="https://getpsalm.org/schema/config"
-    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-    errorBaseline="psalm-baseline.xml"
->
-    <projectFiles>
-        <directory name="Collector" />
-        <directory name="DependencyInjection" />
-        <directory name="MigrationsFactory" />
-        <directory name="Tests" />
-        <file name="DoctrineMigrationsBundle.php" />
-        <ignoreFiles>
-            <directory name="vendor" />
-        </ignoreFiles>
-    </projectFiles>
-    <plugins>
-        <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
-        <pluginClass class="Psalm\SymfonyPsalmPlugin\Plugin" />
-    </plugins>
-</psalm>