Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Client-Side JavaScript #48

Open
imaustink opened this issue Apr 28, 2017 · 0 comments
Open

Refactor Client-Side JavaScript #48

imaustink opened this issue Apr 28, 2017 · 0 comments

Comments

@imaustink
Copy link
Contributor

imaustink commented Apr 28, 2017 •
edited
Loading

Much of the client JS has become unruly, static.js for example, is a pile of spaghetti heavily spiced with jQuery.

I propose the following changes:

  • Refactor all of /static/static.js.
    • Modularize/Organize into components.
    • Use CanJS instead of jQuery where possible.
    • Consider using Bootstrap's scroll spy plugin.
  • Remove plugins from /static/js
    • Replace with NPM modules
    • Consider rewriting them with CanJS
  • Remove most or all of the JS for responsive stuff. Everything I have seen so far could be done with pure CSS.
  • Write tests for as much of the client code as is reasonable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imaustink