Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file support #65

Open
frank-dspeed opened this issue Sep 23, 2017 · 4 comments
Open

Add configuration file support #65

frank-dspeed opened this issue Sep 23, 2017 · 4 comments

Comments

@frank-dspeed
Copy link

i want to create a PR for a configuration file please lets discuss what you would prefer for name and that i will simply add all cli options to it this way done-serve gets a middelware like discussed in other issues.

@matthewp
Copy link
Contributor

What would the config file do?

@frank-dspeed
Copy link
Author

frank-dspeed commented Feb 21, 2018

@matthewp it would handle all manual passed cli options
based on NODE_ENV

-p, --port
-r, --proxy
-t, --proxy-to
--proxy-no-cert-check
-d, --develop
-s, --static
--error-page
--timeout
--debug
--key
--cert

it could be called .donejs
and include donejs related stuff. alternativ done-serve package json property ??

@matthewp
Copy link
Contributor

That should be the same as doing:

const serve = require("done-serve");

serve({
  port: 8081,
  key: ...
});

Maybe we should just document that it can be used like this?

@frank-dspeed
Copy link
Author

@matthewp i am for a configuration option that get saved with the project so we can avoid the npm scripts for that so that running done-serve in a project directory simply works with what ever NODE_ENV is set we also should enable a new random port option to run more then one done-serve instance at the same time i am at present preparing "steal-livereload" middleware but it takes a bit longer because i striped out all relevant parts of steal-tools to don't have it as dependency and clean rewrite the stream stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants