Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to configure additional zone plugins #199

Open
3 tasks
marshallswain opened this issue Dec 9, 2016 · 0 comments
Open
3 tasks

Make it possible to configure additional zone plugins #199

marshallswain opened this issue Dec 9, 2016 · 0 comments
Assignees
@marshallswain

Comments

@marshallswain
Copy link
Member

  • Allow DoneSSR to receive an options.zones array with additional plugins.
  • Update this line to be plugins: zonePlugins.concat(options.zones || [])
  • Add a test that
    • creates a zone plugin that has a beforeTask hook
    • does an assert.ok(true) in the beforeTask that would verifies that the custom plugin is used.
@marshallswain marshallswain self-assigned this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marshallswain marshallswain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marshallswain