-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Size regression of dotnet/runtime sample app (13 Regressions on 1/18/2025 8:01:03 AM) #111673
Comments
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
Range of the regression is 73a9330...7790117. Most likely introduced by new APIs from #111179 @tannergooding . |
@matouskozak is something rooting these? I'd expect that the trimmer would remove them by default since nothing in the BCL consumes them directly today. |
I'm unsure how exactly the trimmer would behave on iOS Mono FullAOT. Maybe @kotlarmilos knows? |
Yes, they are rooted somewhere. Check out symbols from #110406 (comment). |
@kotlarmilos thanks for the reference! I'm a bit confused as to why some of those symbols are rooted. It seems like its flowing through That is, for example, I expect this is just something the trimmer doesn't support today? Given the regression listed here from the handful of new APIs, the sheer number of total APIs that exist on ISimdVector and other types for similar interfaces like INumber and friends, this seems like something that would get some decent wins if it were handled. |
Run Information
Regressions in SOD - iOS HelloWorld .app Size llvm nosymbols
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Repro Steps
Prerequisites (Build files either built locally or downloaded from payload above)
runtime/artifacts
or build instructions: Libraries README args:-subset libs+libs.tests -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/coreclr/$RunOS.$RunArch.Release
, build instructions: CoreCLR README args:-subset clr+libs -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/mono/$RunOS.$RunArch.Release
, build instructions: MONO README args:-arch $RunArch -os $RunOS -s mono+libs+host+packs -c Release
Linux
Windows
SOD - iOS HelloWorld .app Size llvm nosymbols
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in SOD - iOS HelloWorld Zip Size llvm nosymbols
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Repro Steps
Prerequisites (Build files either built locally or downloaded from payload above)
runtime/artifacts
or build instructions: Libraries README args:-subset libs+libs.tests -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/coreclr/$RunOS.$RunArch.Release
, build instructions: CoreCLR README args:-subset clr+libs -rc release -configuration Release -arch $RunArch -framework net8.0
runtime/artifacts/bin/mono/$RunOS.$RunArch.Release
, build instructions: MONO README args:-arch $RunArch -os $RunOS -s mono+libs+host+packs -c Release
Linux
Windows
SOD - iOS HelloWorld Zip Size llvm nosymbols
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: