Running import { test, fc } from '@fast-check/jest'; results in error reading properties of undefined in jest

[CMCDragonkai]

🐛 Bug Report

I'm trying to use the latest ESM version of @fast-check/jest. I got everything else working.

As soon as I try to import import { test, fc } from '@fast-check/jest'; there seems to be some problem with some undefined property.

  ● Test suite failed to run

    TypeError: Cannot read properties of undefined (reading 'only')

      at internalTestPropConcurrent (node_modules/@fast-check/jest/lib/esm/internals/TestPropBuilder.js:25:43)
      at internalTestProp (node_modules/@fast-check/jest/lib/esm/internals/TestPropBuilder.js:32:18)
      at node_modules/@fast-check/jest/lib/esm/jest-fast-check.js:7:25

Seems something isn't quite working..

To Reproduce

Steps to reproduce:

1. Go here Migrating to ESM MatrixAI/js-table#3
2. Try to run npm test

Expected behavior

Clear and concise description of what you expected to happen.

That it just imports properly.

If you have one, please provide a minimal repository reproducing the issue on GitHub.

Your environment

Packages / Softwares	Version(s)
fast-check	^3.10.0
node	v20.5.1
TypeScript*	^5.1.6

*Only for TypeScript's users

[CMCDragonkai]

This line in node_modules/@fast-check/jest/lib/esm/jest-fast-check.js.

import { it as itJest, test as testJest, jest } from '@jest/globals';

Doesn't work as testJest is undefined. It appears it does not exist. However jest does exist.

[CMCDragonkai]

This is the latest version of jest. So I don't think the @jest/globals exports the test property anymore.

[dubzzz]

Strange... I have some tests checking ES Module mode 🤔 (tests here)
I'll check if they correctly setup Jest for such usage...

In he meantime, a shorter and minimal reproduction case could help me into investigating. Current test case is a bit too huge to start an investigation without loosing time trying to understand how the project works, is setup...

[dubzzz]

I'll probably check and extend my tests to use the test and not the testProp thing so that it gets closer to my latest recommendations.

[CMCDragonkai]

Well I sort of debugged it by editing these 3 files:

      at internalTestPropConcurrent (node_modules/@fast-check/jest/lib/esm/internals/TestPropBuilder.js:25:43)
      at internalTestProp (node_modules/@fast-check/jest/lib/esm/internals/TestPropBuilder.js:32:18)
      at node_modules/@fast-check/jest/lib/esm/jest-fast-check.js:7:25

Monkey patching it with console.log indicated this #4986 (comment) being the problem.

I don't think @jest/globals exports test anymore.

[CMCDragonkai]

If you have nix-shell, you can just enter nix-shell first.

If not, an npm install then npm test should suffice.

[dubzzz]

Closing, cannot repro, no minimal case provided.

Sorry, I have to close, I cannot spend time on investigating on exotic setups. If you want me to investigate something please feel free to re-open with a minimal reproduction not forcing me to download many modules unrelated to the bug itself. A case with fast-check plus the test runner you used should probably be enough to reproduce the issue.

[amydevs]

i think it turns out to be something to do with importing from @jest/globals working improperly with @swc/jest https://github.com/swc-project/jest/issues/120. Simply patching out the imports with const {...} = global; seems to work fine.

diff --git a/node_modules/@fast-check/jest/lib/jest-fast-check.js b/node_modules/@fast-check/jest/lib/jest-fast-check.js
index 9fe5a3d..8d2c980 100644
--- a/node_modules/@fast-check/jest/lib/jest-fast-check.js
+++ b/node_modules/@fast-check/jest/lib/jest-fast-check.js
@@ -1,5 +1,5 @@
 import * as fc from 'fast-check';
-import { it as itJest, test as testJest, jest } from '@jest/globals';
+const { it: itJest, test: testJest, jest } = globalThis;
 import { buildTest } from './internals/TestBuilder.js';
 export const test = buildTest(testJest, jest, fc);
 export const it = buildTest(itJest, jest, fc);

The reason for this is because importing @jest/globals breaks swc's hoisting of the jest globals.
https://github.com/swc-project/jest/issues/120

[CMCDragonkai]

@dubzzz can you have a look at @amydevs fix and see if we can apply it to the repo here?

[dubzzz]

Why not. Let's try. CI should warn us if it breaks something

[CMCDragonkai]

Do you want a PR to just do the above patch?

[dubzzz]

Go ahead, yes 👍