Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade expo to the latest version #565

Merged
merged 26 commits into from
Apr 3, 2023
Merged

chore: upgrade expo to the latest version #565

merged 26 commits into from
Apr 3, 2023

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Apr 1, 2023 •
edited
Loading

Description

  • to Upgrade Expo to the latest version #547
  • as a requirement, also upgraded to react 18 across the repo
  • ./mobile app is now a blank Expo 48 app.
  • @dzcode/ui-mobile tests are broken
  • kept old ./mobile as ./mobile-old, will remove it once we re-write the mobile app again.

Type of change

  • chore

@ZibanPirate ZibanPirate self-assigned this Apr 1, 2023
@ZibanPirate ZibanPirate linked an issue Apr 1, 2023 that may be closed by this pull request
Upgrade Expo to the latest version #547
Closed
@github-actions github-actions bot added api API related changes ( api folder ) mobile Mobile related changes ( mobile folder ) models models package ui ui package ui-mobile ui-mobile package utils utils package web Web related changes ( web folder ) labels Apr 1, 2023
@ZibanPirate ZibanPirate changed the title 547 upgrade expo to the latest version 1 chore: upgrade expo to the latest version Apr 1, 2023
@github-actions github-actions bot added the data Data related changes ( data folder ) label Apr 1, 2023
@omdxp
Copy link
Member

omdxp commented Apr 1, 2023

this is a better approach 🚀

@ZibanPirate ZibanPirate force-pushed the 547-upgrade-expo-to-the-latest-version-1 branch from 55acfce to 72e502a Compare April 2, 2023 13:14
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:javascript/node-version:18.x. As part of the setup process, we have scanned this repository and found 8 existing alerts. Please check the repository Security tab to see all alerts.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 2, 2023
View reviewed changes
mobile-old/metro.config.js Fixed Show fixed Hide fixed
ZibanPirate
ZibanPirate commented Apr 3, 2023
View reviewed changes
mobile/.expo-shared/assets.json Outdated Show resolved Hide resolved
mobile/README.md Outdated Show resolved Hide resolved
packages/ui-mobile/package.json Show resolved Hide resolved
packages/ui-mobile/src/markdown/index.tsx Show resolved Hide resolved
packages/ui/src/_types/index.ts Show resolved Hide resolved
patches/@sentry-internal+tracing+7.46.0.patch Outdated Show resolved Hide resolved
@ZibanPirate ZibanPirate added this to the Giving ./mobile some love milestone Apr 3, 2023
@ZibanPirate ZibanPirate marked this pull request as ready for review April 3, 2023 00:37
@github-actions github-actions bot added the tooling tooling package label Apr 3, 2023
@ZibanPirate ZibanPirate requested a review from a team April 3, 2023 03:08
omdxp
omdxp approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@ZibanPirate ZibanPirate merged commit 9a81c50 into main Apr 3, 2023
@ZibanPirate ZibanPirate deleted the 547-upgrade-expo-to-the-latest-version-1 branch April 3, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees

@ZibanPirate ZibanPirate

Labels
api API related changes ( api folder ) data Data related changes ( data folder ) mobile Mobile related changes ( mobile folder ) models models package tooling tooling package ui ui package ui-mobile ui-mobile package utils utils package web Web related changes ( web folder )
Projects
DzCode i/o
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Expo to the latest version
2 participants
@ZibanPirate @omdxp