Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues with breadcrumbs component #82

Open
certainlyakey opened this issue Apr 19, 2023 · 1 comment
Open

Fix accessibility issues with breadcrumbs component #82

certainlyakey opened this issue Apr 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@certainlyakey
Copy link
Contributor

What happened?

The breadcrumbs component lacks accessibility (and usability partially is also hurt) - href attribute is missing (see eg. here why this is an issue). The links in the breadcrumbs must have URLs provided.

As a part of this issue all necessary optimisations allowing for the best experience in a screen reader should be done (based on testing with screen reader software). Eg. nav or aria-label could help with the correct comprehension of the component in assistive devices as a "proper" breadcrumbs widget.

Reproduction steps

  1. Go to https://e-gov.github.io/cvi/?path=/story/angular-breadcrumbs--default
  2. Check the generated markup
  3. Expected: links have hrefs
  4. Observed: hrefs are absent

Screenshot

No response

Package

Angular

Version

1.8.0

Reproduction URL

https://e-gov.github.io/cvi/?path=/story/angular-breadcrumbs--default

Browser

No response

Browser version

No response

Extra details about your environment

No response

Relevant log output

No response

@certainlyakey certainlyakey added the bug Something isn't working label Apr 19, 2023
@certainlyakey
Copy link
Contributor Author

@ekateriinal is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant