Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lucene.xml]: #477

Open
PietroLiuzzo opened this issue May 18, 2020 · 4 comments
Open

[lucene.xml]: #477

PietroLiuzzo opened this issue May 18, 2020 · 4 comments

Comments

@PietroLiuzzo
Copy link

https://exist-db.slack.com/archives/CG2MRUZ35/p1589783299329600
Describe the problem
the $options parameter in function ft:query takes either a map or XML apparently but the documentation and guidelines for additional parameters say it takes only XML, while the facets/fields $options have an example with a map, like map{facets:map{}}

I would suggest in this page to change to something like this

<para>The <code>ft:query</code> function allows a third parameter for passing additional
                settings to the query engine. This parameter must be an XML fragment which lists the
                configuration properties to be set as child elements:</para>
                settings to the query engine. This parameter can be a map or an XML fragment which
                lists the configuration properties to be set as child elements. Using a map will
                allow to include also options for facets and fields. The following is an example
                using XML and only with the additional parameters:</para>
@welcome
Copy link

welcome bot commented May 18, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@PietroLiuzzo
Copy link
Author

sure, I can try (fork and PR, right? not branch, because I have no writing permissions), but I am not sure what actions should be taken in the indexing.xml page, and I do not know what the Query.java file is at all... I would have minimally fixed only the lucene.xml

@adamretter
Copy link
Contributor

adamretter commented May 19, 2020

Hi @PietroLiuzzo Yes a fork and PR.

Well I wasn't sure if it was the indexing.xml page you wanted to update or not? It corresponds to the documentation page - http://www.exist-db.org/exist/apps/doc/indexing.

Regards the Query.java file, near the top it defines the description of the ft:query function that you see in the eXist-db Function Docs. You don't need to actually understand the Java here, you can just edit the textual parts to change the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants