Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

[CORE]Unit tests needs to change not to use container overide #107

Open
oliverde8 opened this issue Sep 27, 2017 · 1 comment
Open

[CORE]Unit tests needs to change not to use container overide #107

oliverde8 opened this issue Sep 27, 2017 · 1 comment
Assignees
@oliverde8
Labels
1. Todo ⚙️ Stuff that needs to be done, but not a feature. 2. High 👍 Priority good first issue ⚡

Comments

@oliverde8
Copy link
Member

It worked fine with SF3.2 but it's deprecated with 3.3 and even caused some issues in some tests.

No hurry as all works well, new tests should take this into consideration. This ticket is to migrate existing tests.
@oliverde8 oliverde8 added 1. Todo ⚙️ Stuff that needs to be done, but not a feature. 2. Medium Priority labels Sep 27, 2017
@oliverde8 oliverde8 self-assigned this Sep 27, 2017
@oliverde8
Copy link
Member Author

Increasing the priority as this blocks upgrade to Symfony3.4 which is an LTS.
And to symfony4 which could allow us to diminish the footprint of eXpansion relatively easily.

I am also tagging it with good first issue as it can be a nice exercise to learn to write unit tests and understand some of the core.

oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved Guihandler test to work without requiring the container.
b444ec7
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved WindoTest test to work without requiring the container.
a16f7f8
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved ChatCommandDataProvider test to work without requirin…
f506f0c 
…g the container.
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved Manialink Factory test to work without requiring the …
89d1612 
…container.
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved GridBuilder test to work without requiring the contai…
9f2ca4c 
…ner, debrecated old TestCore.
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved AbstractChatCommandTest test to work without requirin…
b6d564c 
…g the container.
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved ChatNotificationTest test to work without requiring t…
21e3916 
…he container.
oliverde8 added a commit that referenced this issue Dec 14, 2017
@oliverde8
#107 - Improved JobRunner FactoryTest test to work without requiring …
79cf933 
…the container.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oliverde8 oliverde8

Labels
1. Todo ⚙️ Stuff that needs to be done, but not a feature. 2. High 👍 Priority good first issue ⚡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverde8