Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerance tests fail without -std=f2008 #318

Open
skosukhin opened this issue Jan 2, 2025 · 0 comments
Open

Tolerance tests fail without -std=f2008 #318

skosukhin opened this issue Jan 2, 2025 · 0 comments

Comments

@skosukhin
Copy link
Collaborator

CI fails if we build the project with gfortran and without the -std=f2008 flag.

We have several options:

  1. Update CMake scripts so that the project is always built with the flag if the compiler is gfortran. I don't like this idea because it is not clear what we should do with other compilers. Inject similar flags for them too?
  2. Figure out why exactly the flag changes the results and rewrite the relevant part of the code so that it is not sensitive to the flag anymore.
  3. Adjust the tolerance threshold. It also makes sense to generate the reference data consistently (preferably with a CI job) with gfortran and no extra flags (i.e. with -DCMAKE_BUILD_TYPE=None -DCMAKE_Fortran_FLAGS=).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant