Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File moving should not be done on a patch version #61

Open
soullivaneuh opened this issue Sep 20, 2016 · 1 comment
Open

File moving should not be done on a patch version #61

soullivaneuh opened this issue Sep 20, 2016 · 1 comment

Comments

@soullivaneuh
Copy link

Apparently, you moved a file to the dist folder on patch version: 0.4.4...0.4.5

This is completely BC break. For my case, my asset compiler broke because of a not found file:

  [RuntimeException]                                                                       
  The source file "/code/app/../web/assets/lib/filer.js/src/filer.min.js" does not exist.  

If you follow semver conventions, this kind of things should be done on a major version for a stable project or a minor for an unstable 0.x one (this is your case AFAIK), but never on a patch version.

This is OK now and I hope this issue will help people searching why the new patch version is not working anymore.

Thank you fore reading and considering this issue. 😉

Regards

@ebidel
Copy link
Owner

ebidel commented Sep 20, 2016

Yes you're right this should have been a minor version and explained in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants