Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Services return collected Iterables and not Streams #3682

Closed
ndr-brt opened this issue Dec 1, 2023 · 0 comments · Fixed by #3685
Closed

feat: make Services return collected Iterables and not Streams #3682

ndr-brt opened this issue Dec 1, 2023 · 0 comments · Fixed by #3685
Assignees
@ndr-brt
Labels
refactoring Cleaning up code and dependencies
Milestone
Milestone 13

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Dec 1, 2023

Feature Request

Currently pretty much all the services in the codebase return Stream objects, that could be an issue when used without a wrapped transaction context around that takes care of finalizing the connection in the right manner (and avoiding bugs like #3640 ).

Which Areas Would Be Affected?

services

Why Is the Feature Desired?

refactor

Solution Proposal

If possible, provide a (brief!) solution proposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndr-brt ndr-brt

Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 13
Development

Successfully merging a pull request may close this issue.

refactor: make Services return Lists and not Streams Think-iT-Labs/edc-connector
1 participant
@ndr-brt