Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official docker image on hub.docker.com #76

Open
bilogic opened this issue Oct 8, 2024 · 10 comments
Open

Official docker image on hub.docker.com #76

bilogic opened this issue Oct 8, 2024 · 10 comments

Comments

@bilogic
Copy link

bilogic commented Oct 8, 2024

Would be great if there was an official docker image on hub.docker.com, then we can have a standalone docker-compose.yaml for deployment. The current docker-compose.yaml requires a git clone first.

The impact of having this is to make it easier for everyone to host their own server (and take pressure off the one provided by TypeFox)

@msujew
Copy link
Contributor

msujew commented Oct 21, 2024

Hey @bilogic,

take pressure off the one provided by TypeFox

It's not like there's a lot of traffic on our public instance (99% idle) as of now, but I appreciate the notion. I also believe it makes sense to provide a standalone docker image. @spoenemann Do we have a TypeFox docker hub account that we can use for that?

@bilogic
Copy link
Author

bilogic commented Oct 22, 2024

Cool! Btw I came across this https://github.com/PeerCodeProject/PeerCode, they have a sharable terminal although I could not get it to work in code-server yet.

@msujew
Copy link
Contributor

msujew commented Oct 22, 2024

@bilogic Thanks for the hint, I wasn't aware of the project. They use a very similar approach to our project (but based on WebRTC instead of HTTP).

they have a sharable terminal although I could not get it to work in code-server yet.

Microsoft hides their terminal sharing API behind a proposedApi flag, which is why we havent't gotten to this yet. I'll take a look at how the linked project attempts to work around that limitation.

@bilogic
Copy link
Author

bilogic commented Oct 22, 2024

@msujew thanks, if I may, an important feature is to also show the other side the text I have highlighted, both code and terminal, simply because we cannot physically point on the remote screen😅

@msujew
Copy link
Contributor

msujew commented Oct 22, 2024

if I may, an important feature is to also show the other side the text I have highlighted, both code and terminal, simply because we cannot physically point on the remote screen

Good idea, but AFAIK the VS Code API does not expose a way to provide terminal decorations (for xterm.js), like it does for editors. So we're kinda limited in that regard. I'll keep that in mind for our integration into other IDEs.

@bilogic
Copy link
Author

bilogic commented Oct 22, 2024

Hmm, but if Liveshare was able to do it, then any other extension should as well yea? Or did you mean just the highlighting part?

@bilogic
Copy link
Author

bilogic commented Oct 23, 2024

Oh, sorry, I'm finally piecing it together, proposeApi, maybe PeerCode is doing the same.

@msujew
Copy link
Contributor

msujew commented Oct 23, 2024

Oh, sorry, I'm finally piecing it together, proposeApi, maybe PeerCode is doing the same.

As far as I could tell, they don't. Generally, even though it's supposed to be "proposedApi" (and supposed to eventually become mature, public API) the Microsoft team behind VS Code is known to essentially hide parts of VS Code for their own use. Non-Microsoft VS Code extensions don't have access to that API unless they hack themselves into it, which is pretty frowned-up upon (but theoretically possible for us as a last resort).

@bilogic
Copy link
Author

bilogic commented Jan 5, 2025

any chance of a sharable terminal happening?

@msujew
Copy link
Contributor

msujew commented Jan 5, 2025

@bilogic We plan to look into it, but are currently tight on resources (see the recent lack of activity on the project). We want to work more on the project this year, likely picking up more speed in March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants