Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Valhalla tests to avoid dependencies between test methods #10419

Closed
Leonardo2718 opened this issue Aug 19, 2020 · 2 comments
Closed
Labels
comp:test project:valhalla Used to track Project Valhalla related work

Comments

@Leonardo2718
Copy link
Contributor

Currently, Valhalla tests are structured so that dependencies between various tests exist, resulting in certain tests having to be run before other ones. In most cases, the dependencies are caused by certain tests performing some setup work that's also needed by other tests. To make the tests easier to work with, the tests should be refactored so that any kind of prerequisite work is done in special setup methods. Moving code in this way is likely to require splitting up the test methods across a few test classes. The benefits will be:

  1. being able to run test method individually without having to worry about figuring out which other tests need to be run first
  2. it should become possible to run all tests multiple times while only running the necessary setup once
@theresa-m
Copy link
Contributor

This should be resolved when we transition to the src_lw5 version of ValueTypeTests which does not rely as heavily on asm. See #18558.
fyi @hangshao0 I think this can be closed.

Copy link

Issue Number: 10419
Status: Closed
Actual Components: comp:test, project:valhalla
Actual Assignees: No one :(
PR Assignees: Leonardo2718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

No branches or pull requests

3 participants