Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete code surrounded by opt_panama and Panama flags #11269

Closed
babsingh opened this issue Nov 24, 2020 · 3 comments
Closed

Delete code surrounded by opt_panama and Panama flags #11269

babsingh opened this issue Nov 24, 2020 · 3 comments
Labels
comp:vm project:panama Used to track Project Panama related work

Comments

@babsingh
Copy link
Contributor

babsingh commented Nov 24, 2020 •
edited
Loading

opt_panama: J9VM_OPT_PANAMA surrounds the native code
Panama: JCL flag surrounds the Java code

The above flags highlight OpenJ9's implementation for the NativeMethodHandle and Foreign Linker API (JEP389).

The above OpenJ9 implementation can be deleted since it will be superseded by the OpenJDK implementation.

The MHInterpreter code can be retained since it can be repurposed.
@babsingh
Copy link
Contributor Author

fyi @tajila

@babsingh
Copy link
Contributor Author

#11267 (comment):

I tried to turn-on the opt_panama and Panama (JCL) flags in order to enable the OpenJ9 NativeMethodHandle support. But, I ended up facing many issues:

  1. jdk.internal.nicl and java.nicl packages no longer exist in JDK16. Finding their new equivalent representation will take some time.
  2. MethodHandles class no longer has the findNative* methods.
  3. Library class is no longer available; potentially renamed to NativeLibrary and relocated.
  4. gcc error: Jit.hpp in JavaMethodCallbackGen.cpp cannot be found.
  5. ... the list goes on

@tajila tajila added comp:vm project:panama Used to track Project Panama related work labels Nov 24, 2020
@babsingh babsingh mentioned this issue Dec 10, 2020
Merged
babsingh added a commit to babsingh/openj9 that referenced this issue Dec 14, 2020
@babsingh @tajila
Remove OpenJ9 Java code surrounded by the Panama JPP flag
af5024b 
Related: eclipse-openj9#11269

This PR only removes the:
- Java code surrounded by the Panama JPP flag
- PANAMA JPP configuration
- Panama JPP flag

The corresponding native and test code will be be removed in separate
PRs.

Co-authored-by: Tobi Ajila <[email protected]>
Signed-off-by: Babneet Singh <[email protected]>
@ChengJin01
Copy link

Everything with J9VM_OPT_PANAMA was totally removed via #19862 given the functionalities for Project Panama has been fully implemented in OpenJ9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:vm project:panama Used to track Project Panama related work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@babsingh @tajila @ChengJin01