Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up relocation record binary templates #11659

Closed
dsouzai opened this issue Jan 14, 2021 · 1 comment
Closed

Clean up relocation record binary templates #11659

dsouzai opened this issue Jan 14, 2021 · 1 comment

Comments

@dsouzai
Copy link
Contributor

dsouzai commented Jan 14, 2021

The TR_RelocationRecordBinaryTemplate and related types are used to write data into a buffer that is stored into the SCC. This data is used at AOT load time to materialize the new value for relocation. Prior to #11235, this data was written into the buffer using raw pointer manipulation. However, since this will no longer be the case, requiring fields in the various templates to be UDATA, as well as fields such as

#if defined(TR_HOST_64BIT)
   uint32_t _extra;
#endif

are no longer needed. The templates should be cleaned up to use types that better represent the data in each field.

@dsouzai
Copy link
Contributor Author

dsouzai commented Aug 15, 2024

Cleaned up in #17621

@dsouzai dsouzai closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant