Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueTypes: Fix and enable testDefaultValueWithNonValueType in ValueTypeTests #12197

Closed
OussamaSaoudi opened this issue Mar 11, 2021 · 2 comments · Fixed by #20473
Closed

ValueTypes: Fix and enable testDefaultValueWithNonValueType in ValueTypeTests #12197

OussamaSaoudi opened this issue Mar 11, 2021 · 2 comments · Fixed by #20473
Labels
comp:vm project:valhalla Used to track Project Valhalla related work

Comments

@OussamaSaoudi
Copy link
Contributor

testDefaultValueWithNonValueType has been disabled in PR #11560 to allow hotspot to run ValueTypeTests. The test is disabled because the change performed to make it work with hotspot has made it to longer work with OpenJ9.

When makeValueTypeDefaultValue is called in the ValueTypeGenerator, it now passes the classname as either an L-type or a Q-type to defaultvalue, instead of always a Q-type.

mv.visitTypeInsn(DEFAULTVALUE, getSigFromSimpleName(valueName, isRef));
instead of
mv.visitTypeInsn(DEFAULTVALUE, getSigFromSimpleName(valueName, false));

This results in a java.lang.NoClassDefFoundError in OpenJ9.

@OussamaSaoudi
Copy link
Contributor Author

@tajila

Copy link

github-actions bot commented Nov 4, 2024

Issue Number: 12197
Status: Closed
Actual Components: comp:vm, project:valhalla
Actual Assignees: No one :(
PR Assignees: theresa-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants