Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONSTANT_Class verification checks for VTs #12649

Closed
tajila opened this issue May 7, 2021 · 2 comments
Closed

Update CONSTANT_Class verification checks for VTs #12649

tajila opened this issue May 7, 2021 · 2 comments
Labels
comp:vm project:valhalla Used to track Project Valhalla related work

Comments

@tajila
Copy link
Contributor

tajila commented May 7, 2021

With the introduction of VTs CONSTANT_Class descriptions can be simple names, array signatures and now Q type signatures.

Currently we have checks in checkNameImpl that restricts CONSTANT_Class desc to simple names and array signatures, this will cause verification errors when loading a VT classfile:

java.lang.ClassFormatError: JVMCFRE068 class name is invalid; class=runtime/valhalla/inlinetypes/CheckcastTest, offset=0

We need to update checkNameImpl in chverify.c to support qtype signatures for class desc.
@tajila tajila added comp:vm project:valhalla Used to track Project Valhalla related work labels May 7, 2021
@hangshao0
Copy link
Contributor

This is from an obsolete version of spec. It can be closed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Issue Number: 12649
Status: Closed
Actual Components: comp:vm, project:valhalla
Actual Assignees: No one :(
PR Assignees: No one :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tajila @hangshao0