Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javacore 1CIJAVAVERSION does not detect Windows Server 2019 #16126

Closed
paulcheeseman opened this issue Oct 19, 2022 · 9 comments
Closed

Javacore 1CIJAVAVERSION does not detect Windows Server 2019 #16126

paulcheeseman opened this issue Oct 19, 2022 · 9 comments

Comments

@paulcheeseman
Copy link

Java -version output

Reported on IBM Java 8.0.6.20, but this looks like it will affect any JDK that uses OpenJ9/OMR.

Summary of problem

In javacores taken on Windows Server 2019, the Java version information shows the OS as Windows Server 2012, i.e.:

1CIJAVAVERSION JRE 1.8.0 Windows Server 2012 amd64-64 (build 8.0.6.20 - pwa6480sr6fp20-20201120_02(SR6 FP20))

I think this version information is populated by the following code, which appears to have no way of detecting Windows Server 2019:

https://github.com/eclipse/omr/blob/e82572ab6ee5ee0c78b9c9f9228e87a7fa958766/port/win32/omrsysinfo.c#L320-L351

@pshipton
Copy link
Member

eclipse-omr/omr#3648 added support for detecting Windows Server 2019. We're looking specifically for build 1809, perhaps there are other builds of Server 2019. What does ver from a command prompt show?

eclipse-omr/omr#6259 from SR7 FP10 improves support to look for builds >= 17763 and < 20348.

Does FP25 detect Windows Server 2019 correctly? The original change is first in SR6 FP20, but seems to me the java launcher also needs to declare support for Server 2019, otherwise the app runs in a compatibility mode that looks like the previous version.

@paulcheeseman
Copy link
Author

paulcheeseman commented Oct 19, 2022

Thanks Peter. I missed that code further down in omrsysinfo_get_OS_type().

I raised this on someone else's behalf and I don't have access to the environment in which this was being seen. I'll see if I can get the information you asked for, or even better, get the originating team to comment directly in this issue.

@BrownKathy
Copy link

@pshipton , this ticket was raised as result of a report from my customer. I'll ask him to run ver from a command prompt and let us know what it outputs and I'll get back to you. Thank you!

@pshipton
Copy link
Member

pshipton commented Oct 19, 2022

I tried a handy Server 2019 server machines and it shows build 17763. I expect you need 8.0.7.10 or later to fix the OS detection.

@pshipton
Copy link
Member

pshipton commented Oct 19, 2022

Actually I guess 1809 isn't a build number but the ReleaseId. You can look in the registry, at ReleaseId under SOFTWARE\Microsoft\Windows NT\CurrentVersion. Or use PowerShell and run Get-ComputerInfo -Property "WindowsVersion".

On the machine I'm using the javacore shows "Windows Server 2019 10.0 build 10240" with 8.0.6.20 and 8.0.6.25, 8.0.6.30
and "Windows Server 2019 10.0 build 17763" with 8.0.7.10 and 8.0.7.5, 8.0.6.35, 8.0.6.31.

For reference the ver on my machine is "Version 10.0.17763.3406".

@pshipton
Copy link
Member

We've got these fixes in 8.0.6.31 which I suspect resolve the detection.
eclipse-omr/omr#5870 "Better detection of Windows 10 in omrsysinfo_get_OS_type()"
eclipse-omr/omr#5873 "Compute Windows 10 build number in omrsysinfo_get_OS_version()"

@BrownKathy
Copy link

@pshipton , thank you for the info. Are you still in need of my customer's output?

@pshipton
Copy link
Member

I suggest the next step is to have the customer try a newer build to see if the issue has already been resolved. First 8.0.6.31 and if that doesn't work 8.0.7.10. If neither of these work then we'll need to get more information to figure out what is wrong.

@paulcheeseman paulcheeseman closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Issue Number: 16126
Status: Closed
Actual Components: comp:vm, userRaised
Actual Assignees: No one :(
PR Assignees: No one :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants