Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Preload attribute is renamed to LoadableDescriptors in Valhalla #19611

Closed
hangshao0 opened this issue Jun 3, 2024 · 2 comments · Fixed by #20325
Closed

The Preload attribute is renamed to LoadableDescriptors in Valhalla #19611

hangshao0 opened this issue Jun 3, 2024 · 2 comments · Fixed by #20325
Labels
comp:vm project:valhalla Used to track Project Valhalla related work

Comments

@hangshao0
Copy link
Contributor

hangshao0 commented Jun 3, 2024

See the latest spec;

The Preload attribute (#17233) is now renamed to LoadableDescriptors.

Also the Preload attribute has the following format:

Preload_attribute {
    u2 attribute_name_index;
    u4 attribute_length;
    u2 number_of_classes;
    u2 classes[number_of_classes];
}

The LoadableDescriptors attribute has the following format:

LoadableDescriptors_attribute {
    u2 attribute_name_index;
    u4 attribute_length;
    u2 number_of_descriptors;
    u2 descriptors[number_of_descriptors];
}

Each entry in the descriptors array must be a valid index into the constant_pool table. The constant_pool entry at that index must be a CONSTANT_Utf8_info structure representing a valid field descriptor.

Instead of CONSTANT_Class_info used in Preload, LoadableDescriptors uses field descriptor.

@hangshao0 hangshao0 added comp:vm project:valhalla Used to track Project Valhalla related work labels Jun 3, 2024
@hangshao0
Copy link
Contributor Author

FYI @theresa-m @hzongaro @a7ehuo

Copy link

Issue Number: 19611
Status: Closed
Actual Components: comp:vm, project:valhalla
Actual Assignees: No one :(
PR Assignees: theresa-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant