Update com.ibm.autocvt to default to true unless file.encoding is set #19924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the results of the tests: z/OS Build: [Build_JDK21_s390x_zos_Personal/1133] |
keithc-ca
reviewed
Jul 26, 2024
joransiu
force-pushed
the
autocvt-default
branch
from
0678ea1 to
eb00e99
Compare
keithc-ca
reviewed
Jul 26, 2024
joransiu
force-pushed
the
autocvt-default
branch
from
eb00e99 to
8c76fc4
Compare
Updated. Thanks. |
keithc-ca
reviewed
Jul 26, 2024
The z/OS specific com.ibm.autocvt property should default to true only if the file.encoding property is unset. If file.encoding is set to a specific charset or COMPAT, then we disable auto conversion to retain the same behaviour as JDK17 and earlier releases. Signed-off-by: Joran Siu <[email protected]>
joransiu
force-pushed
the
autocvt-default
branch
from
8c76fc4 to
5dbfd87
Compare
keithc-ca
approved these changes
Jul 26, 2024
|
This only affects z/OS for which we have no PR testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The z/OS specific com.ibm.autocvt property should default to true only if the file.encoding property is unset. If file.encoding is set to a specific charset or COMPAT, then we disable auto conversion to retain the same behaviour as JDK17 and earlier releases.