-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs introduce .github/CODEOWNERS
for eclipse-tractusx/eclipse-tractusx.github.io
#576
Comments
.github/CODEOWNERS
(for eclipse-tractusx/eclipse-tractusx.github.io.github/CODEOWNERS
for eclipse-tractusx/eclipse-tractusx.github.io
IMHO,
Potential things a
Things that we are limited in my opinion:
|
I would vote for a If someone creates a PR or an Issue for your KIT, you as a KIT developer don't get information that someone wants to change your KIT. You could subscribe to the repository, but in this case, you get notifications for every PR and Issue. Thus, a |
Hi @mhellmeier, |
If it is an external contributor, they may not know that there is a mailing list or Matrix chat. If it were used very actively, it could be spammy since one mail could be sent for every PR. Take a look at the recent Markdown linter issues for the KITs: If there were a I would also like to mention one of the latest GitHub blog posts, discussing such a Happy to hear your opinion on that and how we go on with it! |
I think |
will close this issue but the general idea seems still valid at least from my perspective. |
As this PR is not introduceing branch protection and required review count to the GH Org but to the eclipse-tractusx/eclipse-tractusx.github.io repo only, I would like to require 2 reviewers. For this repository enough stakeholders should be available doing reviews.
Maybe we should also think about to introcude
.github/CODEOWNERS
(for eclipse-tractusx/eclipse-tractusx.github.io). Code owners are automatically assigned to new PRs:https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Originally posted by @carslen in eclipse-tractusx/.eclipsefdn#43 (comment)
The text was updated successfully, but these errors were encountered: