[iOS] Add upgrade banner in the FC47 Primary Course card view #460 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
approved these changes
Jul 11, 2024
|
@forgotvas Tests are failing, could you please take a look? |
|
saeedbashir
reviewed
Jul 12, 2024
Comment on lines
14
to
15
| case auditExpired(date: Date?, sku: String, courseID: String, pacing: String, screen: CourseUpgradeScreen, lmsPrice: Double) | ||
| case upgradeable(date: Date?, sku: String, courseID: String, pacing: String, screen: CourseUpgradeScreen, lmsPrice: Double) |
There was a problem hiding this comment.
How about breaking these cases to multilines to silence the Line Length Violation warning?
|
changed trophy icon based on Moiz comment. |
saeedbashir
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[iOS] Add upgrade banner in the FC47 Primary Course card view openedx#460