Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add my to view all courses #41

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

saeedbashir
Copy link

This PR fixes teh following issue

"Learn > Courses > ""View All Courses (149)"" 

The header for this screen reads ""All Courses"" and is missing ""My"" after ""All"""

@rnr
Copy link
Collaborator

rnr commented Jul 24, 2024

@saeedbashir Should then this View be named as 'All My Courses'?

@saeedbashir
Copy link
Author

@saeedbashir Should then this View be named as 'All My Courses'?

Yes it should be, let me update it.

@rnr
Copy link
Collaborator

rnr commented Jul 24, 2024

@saeedbashir Should then this View be named as 'All My Courses'?

Yes it should be, let me update it.

@saeedbashir please commit Dashboard/Dashboard/SwiftGen/Strings.swift file too - to prevent having changes after build/run

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir saeedbashir merged commit 4170de3 into 2U/develop Jul 25, 2024
3 checks passed
@saeedbashir saeedbashir deleted the saeed/update_viewall_text branch July 25, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants