chore: update tab bar icons for selected unselected states #81
Conversation
|
@saeedbashir |
|
@rnr agreed, if we can easily do a white label script that would be good since there is a difference in icons used by schema and 2U. |
In that case, we will have the same icon for the selected/unselected states for the upstream which doesn't looks good even for making the case. I believe we have already discussed it with Axim and they were ok with the approach. The only thing that will come under discussion while pushing to upstream will be the icons for tabs. In my opinion. we will update the icons in the codebase, and while pushing it to upstream we will see whether the like the icons or not. If not then we will have different copies for upstream and edX. |
@saeedbashir |
|
@rnr I think we can use the same icon that Schema is using. I also think their icon and our icon is the same as per the figma file. For them, the selected and unselected state is a value added for schema. When this PR goes to RG, they can either accept our icons or we can accept theirs no need to maintain different icon sets. It might add complexity for now. We can look at a white label script later. |
| public static let learnActive = ImageAsset(name: "learn_active") | ||
| public static let learnInactive = ImageAsset(name: "learn_inactive") | ||
| public static let profileActive = ImageAsset(name: "profile_active") | ||
| public static let profileInactive = ImageAsset(name: "profile_inactive") | ||
| public static let programs = ImageAsset(name: "programs") |
There was a problem hiding this comment.
There are two modes of TabView mentioned in MainScreenView.swift
- list
- gallery
In list view, we should also add selected and unselected states:
.tabItem {
CoreAssets.programs.swiftUIImage.renderingMode(.template)
Text(CoreLocalization.Mainscreen.programs)
}
If we are not going to maintain list view then we should entirely remove list view related icons and changes.
WDYT?
There was a problem hiding this comment.
The list view is not our need nor the axim, both providers are using gallery view. If any provider wants to use it, they can configure (open PR) according to their need.
* feat: banner when register with already linked social account (#54) * fix: fix lint warnings * chore: added banner when register with already linked social account * style: changed text color --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: fix after merge * chore: update tab bar icons for selected unselected states (#81) * chore: Elm theme improvements on Profile (#82) * chore: fix after merge * fix: fix tab bar color not properly applying (#85) * fix: fix tar bar color not properly applying * chore: parity with android for discover icon * chore: added missed colors --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Update the tan bar icons for selected and unselected states as per the design team feedback
