fix: fix tab bar color not properly applying #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
changed the title
|
@saeedbashir This fix looks good for me! |
|
Changes LGTM! |
shafqat-muneer
approved these changes
Oct 8, 2024
@rnr Done! There was a change for the discover icon after the PR merge, I've also addressed that. |
rnr
approved these changes
Oct 8, 2024
rnr
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: fix tar bar color not properly applying * chore: parity with android for discover icon
rnr
added a commit
that referenced
this pull request
Dec 17, 2024
* feat: banner when register with already linked social account (#54) * fix: fix lint warnings * chore: added banner when register with already linked social account * style: changed text color --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: fix after merge * chore: update tab bar icons for selected unselected states (#81) * chore: Elm theme improvements on Profile (#82) * chore: fix after merge * fix: fix tab bar color not properly applying (#85) * fix: fix tar bar color not properly applying * chore: parity with android for discover icon * chore: added missed colors --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-10246
nav_bar_issue.mov
nav_bar.mov