chore: sign-in and register screens social sign in improvements #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@saeedbashir @moiz994 Should Register screen says "Continue with"?
|
@rnr Yes, here is the axim/schema figma file for the feature; we actually follow their design. And here is the edX design file. |
This comment was marked as resolved.
This comment was marked as resolved.
rnr
reviewed
Nov 18, 2024
Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/Login/SignInViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthView.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthView.swift
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthViewModel.swift
Outdated
Show resolved
Hide resolved
|
After adding the last social sign-in option, the screen's left and right margins became misaligned and need to be fixed.
|
shafqat-muneer
requested changes
Nov 20, 2024
Comment on lines
149
to
150
| completion: { | ||
| _ in |
There was a problem hiding this comment.
Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
There was a problem hiding this comment.
Suggestion: Can we use .svg files here to prevent blurriness on high-resolution screens, even though no issues have been observed so far?
There was a problem hiding this comment.
We are using high-resolution images, so it's not needed.
|
LGTM 👍
|
shafqat-muneer
approved these changes
Nov 22, 2024
rnr
pushed a commit
that referenced
this pull request
Dec 27, 2024
rnr
added a commit
that referenced
this pull request
Jan 9, 2025
* chore: add video and discussion analytics (#93) * fix: fixes after merge, deleted IAP parts * chore: changed dependency version, deleted unused analytics part * chore: regenerate mocks * chore: In app ratings modal and profile picture picture sheet UI improvements (#94) * chore: show subtitles for videos in full-screen mode (#97) * fix: after merge * fix: iOS 18 Toggle tap gesture (#98) * fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <[email protected]> * fix: gesture for ios 18.2 * chore: quick fix with performance for subtitles view * chore: sign-in and register screens social sign in improvements (#95) * chore: fix after merge * fix: fix microsoft login issue on iOS after config branch merges (#96) * refactor: change the microsoft key name in the script (#101) * chore: fix access modifier * chore: re-generate nocks * chore: hide grades when sub section dependents not available (#99) * chore: fix after merge * chore: hide progress points from assignment status (#100) * chore: fix test --------- Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Shafqat Muneer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Tickets:
LEARNER-10296
LEARNER-10297
Config:
https://github.com/edx/edx-mobile-config/pull/186
Screenshots
Note: I haven't implemented the more/less option for the social auth view. As at the moment, maximum 4 social auth options could be configured on mobile and more/less feature would be unused.
cc @moiz994