Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractionResult is not flexible enough for some extractors #36

Open
oflatt opened this issue Apr 29, 2024 · 2 comments
Open

ExtractionResult is not flexible enough for some extractors #36

oflatt opened this issue Apr 29, 2024 · 2 comments

Comments

@oflatt
Copy link
Member

oflatt commented Apr 29, 2024

Some extractors are non-local: for different root eclasses, they extract different sub-terms for the same eclass.
However, the current extraction gym does not allow picking two different nodes for the same eclass.

As a result, the global_greedy_dag extractor sometimes extracts cycles because it chooses conflicting nodes when extracting different roots.

@oflatt
Copy link
Member Author

oflatt commented Apr 29, 2024

I have a simple solution: let's just allow a single root per benchmark.
If you want to benchmark something with multiple roots, just create multiple benchmarks

@oflatt
Copy link
Member Author

oflatt commented Apr 29, 2024

Perhaps there's a more general problem with cycles and DAG extractors- if you allow them to extract a particular term, the problem goes away. However, if they must pick a single term per eclass cycles can occur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant