-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows client support #87
Comments
Hey! |
You're welcome to help implement it! It's the same as before. |
Super looking forward to implementing it on Windows |
Me too! Please give me a holler if you'd like to work on it |
I had some time today and am mostly caught up on emails, so I went ahead and spun up a Windows VM on AWS and made a dev environment. Such a pain to even set up SSH compared to Linux! But that's what it is, remote desktop protocol and so on. There is a PR #99 that adds Windows support to sshx. Please test and let me know if it works for you. You can build within the branch with I'm especially interested in hearing if the shell detection is working right. Powershell doesn't seem to be launching, besides that I'm just auto-detecting for git bash and cmd right now. Anything else people use commonly / stats about this? Cygwin? |
(It looks like due to a bug or some other issue on GitHub, the previous issue for Windows support is not showing up, so I'm going to make a new one.)
The sshx client is mostly cross-platform, except one file
terminal.rs
. To add Windows support, we would need to port terminal.rs to Windows using the ConPTY API.The text was updated successfully, but these errors were encountered: