From 55505ed0df04e1d701d13e0861a3b0f6ff58a4ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABtan=20Gilbert?= <gaetan.gilbert@skyskimmer.net>
Date: Mon, 6 Nov 2023 14:39:11 +0100
Subject: [PATCH] Restore tailrecness of CList.filter

filter2 and filter_with are also nontailrec but let's validate the
idea first.

Alternatives:
- drop preservation of physical equality ("smartness")
- continuation passing instead of mutation
- drop tailrec explicitly (and stop using mutation since it's then
  useless AFAICT)
---
 clib/cList.ml | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/clib/cList.ml b/clib/cList.ml
index ebf501b0a9bf..eda189221f04 100644
--- a/clib/cList.ml
+++ b/clib/cList.ml
@@ -160,20 +160,31 @@ let assign l n e =
 
 (** {6 Filtering} *)
 
-let rec filter_loop f p = function
-  | [] -> ()
-  | x :: l' as l ->
-    let b = f x in
-    filter_loop f p l';
-    if b then if p.tail == l' then p.tail <- l else p.tail <- x :: p.tail
+(* [filter_loop f (Some (c0,l0)) c l] will do c0.tail <- l0 if [for_all f l] *)
+let rec filter_loop f reset p = function
+  | [] -> begin match reset with
+      | None -> ()
+      | Some (c,orig) -> c.tail <- orig
+    end
+  | x :: l as orig ->
+    if f x then
+      let c = { head = x; tail = [] } in
+      let () = p.tail <- cast c in
+      let reset = match reset with
+        | Some _ -> reset
+        | None -> Some (p,orig)
+      in
+      filter_loop f reset c l
+    else
+      filter_loop f None p l
 
 let rec filter f = function
   | [] -> []
-  | x :: l' as l ->
+  | x :: l' as orig ->
     if f x then
       let c = { head = x; tail = [] } in
-      filter_loop f c l';
-      if c.tail == l' then l else cast c
+      filter_loop f None c l';
+      if c.tail == l' then orig else cast c
     else
       filter f l'