Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the max_selections poll parameter #2756

Open
jkhsjdhjs opened this issue Apr 28, 2024 · 2 comments
Open

Support for the max_selections poll parameter #2756

jkhsjdhjs opened this issue Apr 28, 2024 · 2 comments
Labels
A-Polls T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product

Comments

@jkhsjdhjs
Copy link

jkhsjdhjs commented Apr 28, 2024

Is your feature request related to a problem? Please describe.
It is currently not possible to select multiple options on a poll.

Describe the solution you'd like
It should be possible to select multiple options if max_selections allows for it.
Selecting another option shouldn't unselect previously selected options. Instead, selected options may be unselected by tapping them again.

Additional context
See also: element-hq/element-meta#2694

@pixlwave pixlwave added X-Needs-Product T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Polls labels May 3, 2024
@nitn3lav
Copy link

nitn3lav commented Oct 6, 2024

This was already implemented for Element Web. However, the PR matrix-org/matrix-react-sdk#9519 was rejected because it wouldn't be cross platform across all versions of Element. I would be happy to implement this for iOS (both Element X and Element) and I might also take a look at Android. Could you please confirm that this would get merged (if code meets all requirements, etc.)

CC: @dbkr

@stefanceriu
Copy link
Member

Could you please confirm that this would get merged

This is not the right place to ask that question. You should raise a ticket on https://github.com/element-hq/element-meta/issues and have somebody from the products team answer it.

Otherwise, I'm more than happy to look at the underlying implementation and merge it without enabling any changes on the UI level. (mind you, most of this logic should be on the rust side for EX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Polls T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product
Projects
None yet
Development

No branches or pull requests

4 participants